Open link in new tab or new window ✅

emzeweb · September 21, 2022, 1:05pm

Hi all,

after finally resolving my board issues (through re-installing from scratch and re-importing manually my db now running under mysql), here I am back…

A feature that would, in, my opinion, be really helpful is to have links opening in a new browser tab / new browser window as default behaviour (adding target=“_blank” property to links)

Any idea about how to implement this ? (Maybe a plugin exists already to achieve it and I’ve not seen it ?) Or could it be added to the roadmap for a future release ?
Thanks in advance,
eM

alfredb · September 21, 2022, 2:12pm

Welcome back!

Sorry, if I didn’t understand your request. But isn’t that a browser topic?
For me here with Firefox:

Click opens in same window and tab.
Shift-Click opens in a new window.
Ctrl-Click opens in a new tab in background (not focused)
Shift-Ctrl-Click opens in a new tab in foreground (focused)

RainerBielefeld · September 22, 2022, 5:19am

@emzeweb:
I am not sure what exactly your desire might be, also see that more as a browser issue. But – if you haven’t already done – maybe you want to try:

<a href="http://example.com/" target="_blank">example which opens in new Tab</a>

example which opens in new Tab

<a href="http://example.com/">example which opens here</a>

example which opens here

In KANBOARD this will work with installed Plugin ‘MarkdownPlus’

alfredb · September 22, 2022, 8:06am

This doesn’t affect the internal links from KB, e.g., to display a task from the board display.

And BTW, even I have the MarkdownPlus plugin installed as well, I’m quite sure it doesn’t alter this behavior.

emzeweb · September 22, 2022, 10:45am

hi,

sorry if I wasn’t explicit enough in my request. my idea was to find a user-friendly way (i.e. addition in the formatting shortcuts bar, or change in the default behaviour) to make external links open in new tab.
but as you pointed out, this is more a browser usage question, and I guess I’ll just have to make the board users get the habit of ctrl-clicking the links…

thanks for reminding me of the possibilities offered by the browser itself…

as far as Markdown Plus plugin is concerned, it won’t help me here since the end-users of our kanboard are not used to writing html…

creecros · September 23, 2022, 10:33am

the user friendly way, would be to force the behavior, by overriding the template that creates the behavior.

although now im confused:

github.com

kanboard/kanboard/blob/8443f607487a798bc36f9e7df7a59fc96fb68340/app/Template/task_external_link/table.php#L32


      
                      </li>
                      <li>
                          <?= $this->modal->confirm('trash-o', t('Remove'), 'TaskExternalLinkController', 'confirm', array('link_id' => $link['id'], 'task_id' => $task['id'])) ?>
                      </li>
                  </ul>
              </div>
              <?php endif ?>
              <?= $this->text->e($link['type']) ?>
          </td>
          <td>
              <a href="<?= $link['url'] ?>" title="<?= $this->text->e($link['url']) ?>" target="_blank"><?= $this->text->e($link['title']) ?><span class="ui-helper-hidden-accessible"> (<?= $this->text->e($link['url']) ?>)</span></a>
          </td>
          <td>
              <?= $this->text->e($link['dependency_label']) ?>
          </td>
          <td>
              <?= $this->text->e($link['creator_name'] ?: $link['creator_username']) ?>
          </td>
          <td>
              <?= $this->dt->date($link['date_creation']) ?>
          </td>

as far as i can see, it has target = “_blank”

alfredb · September 23, 2022, 10:59am

Yes, whatever you add explicitly as external link to a task, will get opened detached. But there are many other links within KB.

emzeweb · September 23, 2022, 12:37pm

well, yeah, I get what you mean by adding a URL “explicitly as external link to a task” but it’s definitely not the way we do it… I was thinking about the links that are included in the Task Description… but it’ll be alright with ctrl+click. thanks for looking into it anyway.

creecros · September 23, 2022, 5:31pm

oh, so you want the links in the Description to open in a new tab. That runs through parsedown. that is easy to do.

add 'target' => "_blank", after line 1421. Should do the trick.

github.com

kanboard/kanboard/blob/8443f607487a798bc36f9e7df7a59fc96fb68340/vendor/erusev/parsedown/Parsedown.php#L1421


      
              {
                  $url = $matches[0][0];
          
          
        $Inline = array(
                      'extent' => strlen($matches[0][0]),
                      'position' => $matches[0][1],
                      'element' => array(
                          'name' => 'a',
                          'text' => $url,
                          'attributes' => array(
                              'href' => $url,
                          ),
                      ),
                  );
          
          
        return $Inline;
              }
          }
          
          
protected function inlineUrlTag($Excerpt)
          {

If you want more stuff to open in a new tab, there really are only a handfull of places links get interpreted, so its not hard to get them all.

creecros · September 23, 2022, 5:42pm

and 90% of them run through parsedown. 90% is arbitrary, i made that up, but definately “most” links are handled through parsedown. might even be 100% if we are strictly referring to commonly made user links.

And between parsedown and the UrlHelper, might be close to 100% absolute.

github.com

kanboard/kanboard/blob/8443f607487a798bc36f9e7df7a59fc96fb68340/app/Helper/UrlHelper.php#L98


      
           * @param  string  $action      Action name
           * @param  array   $params      Url parameters
           * @param  boolean $csrf        Add a CSRF token
           * @param  string  $class       CSS class attribute
           * @param  string  $title       Link title
           * @param  boolean $newTab      Open the link in a new tab
           * @param  string  $anchor      Link Anchor
           * @param  bool    $absolute
           * @return string
           */
          public function link($label, $controller, $action, array $params = array(), $csrf = false, $class = '', $title = '', $newTab = false, $anchor = '', $absolute = false)
          {
              return '<a href="'.$this->href($controller, $action, $params, $csrf, $anchor, $absolute).'" class="'.$class.'" title=\''.$title.'\' '.($newTab ? 'target="_blank"' : '').'>'.$label.'</a>';
          }
          
          
/**
           * Absolute link
           *
           * @param  string $label
           * @param  string $controller
           * @param  string $action

Here all you need to do is make the default $newTab value true.

emzeweb · September 26, 2022, 8:50am

hey, @creecros, thanks a lot ! this seems to do the trick !!

Topic		Replies	Views
Looking for some advice / plugin to further enhance the user experience Questions	5	500	April 29, 2023
MarkdownPlus Checkmarks do not persist Plugins	16	19	December 25, 2024
New task window too wide for browser	4	467	April 4, 2020
[REQ]: (Working) Tooltips on comments	8	720	November 26, 2018
A new contributor with some questions Questions	0	357	June 6, 2020

Open link in new tab or new window ✅

Related topics