Can we Remove the Unique Project Validator for Project Emails?

aljawaid · January 21, 2023, 6:36am

kanboard/kanboard/blob/5c25755f9e43b6b3ab85a5bc68d7ab4afa5e3534/app/Validator/ProjectValidator.php#L38


      
                  new Validators\Integer('priority_start', t('This value must be an integer')),
                  new Validators\Integer('priority_end', t('This value must be an integer')),
                  new Validators\Integer('is_active', t('This value must be an integer')),
                  new Validators\MaxLength('name', t('The maximum length is %d characters', 65535), 65535),
                  new Validators\MaxLength('identifier', t('The maximum length is %d characters', 50), 50),
                  new Validators\MaxLength('start_date', t('The maximum length is %d characters', 10), 10),
                  new Validators\MaxLength('end_date', t('The maximum length is %d characters', 10), 10),
                  new Validators\AlphaNumeric('identifier', t('This value must be alphanumeric')) ,
                  new Validators\Unique('identifier', t('The identifier must be unique'), $this->db->getConnection(), ProjectModel::TABLE),
                  new Validators\Email('email', t('Email address invalid')) ,
                  new Validators\Unique('email', t('The project email must be unique across all projects'), $this->db->getConnection(), ProjectModel::TABLE),
              );
          }
          
          
/**
           * Validate project creation
           *
           * @access public
           * @param  array   $values           Form values
           * @return array   $valid, $errors   [0] = Success or not, [1] = List of errors
           */

This commit was done 6 years ago, I think it needs changing. I am in a situation where the same email address is being used for different projects but this validator stops me from getting email reports.

Can this line be removed safely? Or can somebody help/guide how adjust the code to allow for the same email address to be used across multiple projects?

Anybody know how to combat this?

alfredb · January 21, 2023, 11:22am

This doesn’t really hit me, I still have the option of defining mail aliases. But this is outside Kanboard.

As I can see, the reason for the requirement “unique” is unknown or at least very vague, the constraint could IMHO be removed, or at least made optional.

aljawaid · January 21, 2023, 1:00pm

there seems to be no way to override it because its not a template so its a core code change sadly but thanks, at least i know its a useless line

alfredb · January 21, 2023, 1:38pm

Beware, it’s just my best guess!

Topic		Replies	Views
New Action Plugin: KanboardEmailHistory Plugins	6	327	January 18, 2023
"Send by email" feature on a task Questions	4	435	July 5, 2019
Mail function and php version Installation Issues	2	545	December 22, 2022
Mail sender change Name Questions	1	505	August 17, 2021
Receiving 100's of e-mail notifications	0	417	September 7, 2019

Can we Remove the Unique Project Validator for Project Emails?

Related Topics