Effect as per Subject, see attached “screenshots” from PDF
Any Ideas how to persuade the pugin to show all pictures?
CU
Rainer
Effect as per Subject, see attached “screenshots” from PDF
Any Ideas how to persuade the pugin to show all pictures?
CU
Rainer
Same ugly effect in Send Task per Email. Kanboard Attachment pictures aremissing, only the one from external source shown.
Also “Public Link” affected, see #2194
And not related to aplugin. I did a test in an extra instllation without any installed plugin, here the public link!
“Task2PDF” will attach files that are “attached” to a task. Best I could do at the time I wrote it, it was over my head at the time.
What that means is, although the PDF isn’t rendering them, if you look at the files attached to the PDF, you will see the files. Find the Paperclip in Acrobat, and there you will see the attachments.
Ah, thank you for the hint. Not optimum, because assignment of PDF attachments to PDF contents is not clear, but, of course, much better than no attachment at all.
But of course, best would be to have the images at their place in the PDF contents.
So the good news is, after hours of hacking away trying to find a solution, I finally solved it. Talk about a pain in the ass. But I can make all the images display on the page.
Bad news is, I need to spend hours more hacking away at formatting the images to fit nicely on the page.
I’m just not good a front end styling and layout.
I am open to any assistance…i’m not sure I have it in me.
I really really like good news.Thx
Unfortunately I can’t help at all.
I’m not either. But AFAIK, @aljawaid is a front end guy.
i might have spoken too soon, i found a couple instances where dompdf just dies trying to interpret the screenshots in the description. not quite there yet.
Never mind, I got it working again, so here is an example, before any formatting etc…just testing it will work with any internal kanboard images, including the Paste Image to Markdown plugin.
Now I need someone to fromat these…
Here is a WIP branch, which clearly has issue, as it is a Work In Progress.
Hey,
i appreciate the work you and all the other great contributers have done to make kanboard a very great and customisable tool.
I will be looking into it, if i can help with the formatting issue!
If you need any explanations let me know.
It’s a bit different than normal frontend stuff, but for the most part, all the layouts are in the Template/printlayout folder. Those templates are only utilized for creating the print layouts, that get sent to dompdf to create the PDF. Aside from that, the print model and controller do a bit as well, mostly the model, which parses out the img tags src
data, gets the img content, base64 encodes it, and replaces the src data, and then shoots it through the Markdown helper to handle the rest of the markdown, and finally that all gets sent to dompdf to create the pdf…
Yes, thank you was about to ask about that but found there on my own!
Ehm i think i got it, please correct me if im wrong. But you had it right, before you “fixed” it
You removed the table you had in before which basically did any formatting you needed?
i created a pull request, please have a look at it and tell me if theres anything else to do. I will check back in from work tomorrow.
greetings
that is a small portion of the issue.
Yes, I removed the table I originally had. Mainly because at the time I was only worried about getting the images to work, those were the easy ones tho. Although I would say, to ensure large images aren’t too large on the sheet, making the PDF 5 pages, it would be nice to thumbnail size those.
The main issue is in the “Description” of the task. You will need MarkdownPlus and PITM to test this, but here is the outcome:
results in:
The image is so large, it covers the description. I am not sure how to account for this.
Ok that went past me earlier, was almost done with my time at work so i was a bit in a hurry ^^
This time i just created a style element (i dont think its important in which file it is lol, since you dont have a dedicated css file for the plugin) which limits images to 100% of the available space, which is defined in the respective containers they are in.
Works perfectly well for my new basic test environment:
Fresh Setup
Task2pdf, MarkdownPlus, PITM
I used to extremely large pictures (4480x1080 and 1080x4480) to test it, no weird behaviour whatsoever.
Since i am not a Frontend guy either, i wasted 4 hours trying to solve it in the backend but nope
<style>
img {
max-width:100%;
max-height:100%;
}
</style>
Ya i dont know, even with that, I’m getting a 10page PDF.
https://www.nachostudio.ml/task/4
username: admin
pw: admin
this doesnt work
Fatal error: Uncaught Error: Class "ParsedownExtra" not found in /var/www/app/plugins/MarkdownPlus/vendor/leblanc-simon/parsedown-checkbox/ParsedownCheckbox.php:10 Stack trace: #0 /var/www/app/plugins/MarkdownPlus/vendor/composer/autoload_real.php(55): require() #1 /var/www/app/plugins/MarkdownPlus/vendor/composer/autoload_real.php(38): composerRequire65a8882e640840f82a5b23de49691603() #2 /var/www/app/plugins/MarkdownPlus/vendor/autoload.php(12): ComposerAutoloaderInit65a8882e640840f82a5b23de49691603::getLoader() #3 /var/www/app/plugins/MarkdownPlus/Helper/MarkdownPlusHelper.php(5): require('...') #4 /var/www/app/vendor/composer/ClassLoader.php(476): include('...') #5 /var/www/app/vendor/composer/ClassLoader.php(344): Composer\Autoload\includeFile() #6 /var/www/app/app/Core/Helper.php(102): Composer\Autoload\ClassLoader->loadClass() #7 /var/www/app/vendor/pimple/pimple/src/Pimple/Container.php(122): Kanboard\Core\Helper->Kanboard\Core\{closure}() #8 /var/www/app/app/Core/Helper.php(86): Pimple\Container->offsetGet() #9 /var/www/app/app/Core/Helper.php(74): Kanboard\Core\Helper->getHelper() #10 /var/www/app/app/Helper/FormHelper.php(191): Kanboard\Core\Helper->__get() #11 /var/www/app/app/Template/auth/index.php(14): Kanboard\Helper\FormHelper->label() #12 /var/www/app/app/Core/Template.php(83): include('...') #13 /var/www/app/app/Helper/LayoutHelper.php(188): Kanboard\Core\Template->render() #14 /var/www/app/app/Helper/LayoutHelper.php(42): Kanboard\Helper\LayoutHelper->pageLayout() #15 /var/www/app/app/Controller/AuthController.php(30): Kanboard\Helper\LayoutHelper->app() #16 /var/www/app/app/Core/Controller/Runner.php(77): Kanboard\Controller\AuthController->login() #17 /var/www/app/app/Core/Controller/Runner.php(31): Kanboard\Core\Controller\Runner->executeController() #18 /var/www/app/index.php(9): Kanboard\Core\Controller\Runner->execute() #19 {main} thrown in /var/www/app/plugins/MarkdownPlus/vendor/leblanc-simon/parsedown-checkbox/ParsedownCheckbox.php on line 10
ya, try now, i was in the process of updating the package
its my dev server, so at any given time i could be doing something