each object can have whatever parameters you want in a json file. It needs the ones it currently has, because KB uses them, but yes you can add more.
The PR is conversation starter though, unless Fred is actually reading this, which I doubt. I know he will see the PR request.
letās seeā¦
I think this may get approved, Frederic has asked to change the property type to boolean and iso-date so I have done that.
I have also pushed a revised readme for easier reading and clearer instructions. Hope that gets approved too.
This doesnāt seem to workā¦ it should return nothing, be ignored right now when I test it (as it doesnt exist in the json file yet)
<?php if ($plugin['has_schema']): ?>
<span class="plugin-schema">
<?= $this->app->tooltipHTML('<p><i class="fa fa-database"></i> '. t('This plugin contains database changes') .'</p>', $icon = 'fa-database') ?>
</span>
<?php endif ?>
or should I change it to: <?php if ($plugin['has_schema'] == true): ?>
because the value will be boolean when pr is merged (if it is)
calling a parameter that does not exist will show up in your stderr logs, as an undefined array key. and if you have said code in a template, it should also be written all over the page.
if it exists, and it is boolean, then you have it right as it is.
if that is not the result that you have, then you have issues somewhere else. I cannot evaluate beyond that without looking at all the code.
You could try this:
<?php if (isset($plugin['has_schema']) && $plugin['has_schema']): ?>
Much better practice
Great work! Personally, But I donāt like the red Uninstall-button. Why in red? This eye-catcher is IMHO unneeded.
hey, glad you like itā¦
I will change the tone of the buttonā¦ user experience is all about the buttonā¦ it is based on the bootstrap danger color scheme for buttons which i remember. Basically, the danger colour serves as a warning to the user.
But I will tone it downā¦also, I will look to hide it to non-admin
Still red. But let it be, if itās following some standards.
cool, lets see how it goesā¦ i will leave it at the toned down colour for nowā¦ the hover makes it less intrusive too.
generally i think the whole table is neater though and easier on the eyeā¦ hope everyone else feels the same once its released if anyone actually uses it lol
Stilll waitingā¦ dont think it will get merged to be honest
Maybe he just hasnāt time. Someone is completely rebuilding the user doc site.
Well that would make sense if Task2pdf was not merged 6hrs ago but it wasā¦
This is what I hate on the concept of pull request. Youāre completely hanging, even if you did a good job with an amount of work. Nobody likes just waiting, with no feedback, completely clueless whether there will be one ever.
Look, for instance, at the wiki plugin. I dropped 2 PRs there with IMHO important fixes, but either nobody cares, or just ignores them.
So what? Iām working with my patched version and try to forget my contribution.
But this is not the way I think FOSS development should work.
Yeh I fully understandā¦ Iām not a developer by professionā¦ I just learn what I use and try to improve it. I think Frederic has limited the success of Kanboard, which is not healthy for FOSS at all.
If my work on the new readme and plugins json doesnt get approved, I will obviously look at alternative ways to use Kanboard and then look for a replacement. It is sad, but Frederic doesnāt realise how behind Kanboard is in features and user experienceā¦ just read half of reddit about people looking for kanban style projects and see what they have to say about Kanboard.
Creecros should be running Kanboard. His proactive approach to the project is very supportive of FOSS. At least he doesnt ever make you feel ignored.
ohhh the wiki pluginā¦ such a mess! I spent a lot of time making the front end of that more presentable but gave up because I could understand the pages mechanismā¦
I dont fork repos because I dont know how to maintain backend codeā¦ Im a self-taught frontend guy. IT development is not my job.
